Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6996 Fix Unable to generate P2TR address via gRPC #7146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rox1338
Copy link

@rox1338 rox1338 commented Mar 12, 2024

See #6996 for more info on the bug.

Disclaimer:
I did this change directly in github and didn't run any tests.
So see this as a suggestion only.
Someone with knowledge of the code needs to have a thorough look.

@rox1338 rox1338 requested a review from cdecker as a code owner March 12, 2024 10:43
@ErikDeSmedt
Copy link
Contributor

I think you're on the right track to diagnose this bug.

The issue is a little bit deeper though. The cln-rpc/src/model.rs-file is auto-generated by msggen.
To fix the bug we need to ensure msggen generates the correct code.

Otherwise, next time msggen is run it will override your changes.

@rox1338
Copy link
Author

rox1338 commented Mar 25, 2024

@ErikDeSmedt You are right.
Would appreciate if someone who knows what he is doing fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants