Replace application icon to proper #42
Open
+10
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andersen27
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old path to application icon (
"Assets/electron.ico") did not work. The Electron default icon was displayed, which can be seen when changing the icon file to another. The following path is correct:"bin/Assets/electron.ico".But in order for the developers to see that the custom icon definition really works, I replaced the icon with the one located in
wwwroot. So the "ElectronNET-API-Demos/Assets/" folder is no longer needed and has been deleted.Also BrowserWindow's icon was defined relative to OS platform (edits inside
electron.manifest.jsonis enough for Windows, but this is a working example that can be useful to developers, specifically for Linux).P.S: Refreshing the icon cache (Windows)