Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /no-restore and SelfContained property support in CLI #847

Merged

Conversation

gorsheninmv
Copy link

@gorsheninmv gorsheninmv commented Apr 29, 2024

/no-restore
It's that MSBuild doesn't have property to control restore policies. These command are implemented in dotnet cli but not in MSBuild.
/no-restore option can be useful for flexlible control in CI\CD pipelines.

SelfContained
Optional --self-contained arg will be useful to reduce package size if the required .net runtime is expected to be installed.

The new options maintain backward compatibilty.

@FlorianRappl
Copy link
Collaborator

LGTM! What's missing to make this PR viable?

@FlorianRappl FlorianRappl changed the base branch from main to develop April 29, 2024 09:45
@gorsheninmv gorsheninmv changed the title Add /no-restore /no-self-contained CLI args Add /no-restore and SelfContained property support in CLI Apr 29, 2024
@gorsheninmv gorsheninmv marked this pull request as ready for review April 29, 2024 10:06
@gorsheninmv
Copy link
Author

LGTM! What's missing to make this PR viable?

Now the PR is ready for review :)

@FlorianRappl FlorianRappl merged commit 6472f34 into ElectronNET:develop Apr 29, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants