Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced TypeScript Development Conformity and Build Flexibility #814

Closed
wants to merge 7 commits into from
Closed

Conversation

Sieluna
Copy link

@Sieluna Sieluna commented Sep 26, 2023

Description:

I have made efforts to align the project more closely with the community's TypeScript development conventions, thereby making the building process more intuitive.

TODO:

  • Separate JS and TS code.
  • Fix "Execute your own typescript code" not working(ElectronNET.WebApp Host Hook not working #815)
  • Update electron from 13 to16
  • Improve build command C# code.
  • Improve start command C# code.
    • Improve JS build logic
  • Improve init command C# code
    • Modified unstable EditLaunchSettings function
      // super stupid implementation, but because there is no nativ way to parse json
      // and cli extensions and other nuget packages are buggy
      // this is should solve the problem for 80% of the users
      // for the other 20% we might fail...
  • Improve add command C# code
  • Improve build performance
    • Parallel build C# and JS
    • (Need some more advices)

* Resolved inconsistencies in code styling across various files.
* Reorganized project structure to better align with common JS module development workflows.
* update to net6.0 because target framework is dot net 6
* Implement TODO at ElectronNET.CLI/Commands/BuildCommand.cs Line 185
@Sieluna
Copy link
Author

Sieluna commented Sep 26, 2023

@FlorianRappl May I ask why there is a need to mark the resource as 'never'?

string itemGroupXmlString = "<ItemGroup>" +
"<Content Update=\"ElectronHostHook\\**\\*.*\">" +
"<CopyToPublishDirectory>Never</CopyToPublishDirectory>" +
"</Content>" +
"</ItemGroup>";

Replaced < and > characters with their respective HTML entities (&lt; and &gt;) within C# code blocks in HTML to ensure correct rendering on the browser. This prevents the characters from being interpreted as HTML tags, ensuring the code block is displayed as intended.
@Sieluna Sieluna closed this by deleting the head repository Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant