feat: allow equals sign in aliased parameter values. #2755
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IMax153
reviewed
Jun 1, 2024
IMax153
requested changes
Jul 1, 2024
| @@ -1193,7 +1193,7 @@ const parseInternal = ( | |||
| const extractKeyValue = ( | |||
| value: string | |||
| ): Effect.Effect<[string, string], ValidationError.ValidationError> => { | |||
| const split = value.trim().split("=") | |||
| const split = value.trim().split(/=(.*)/, 2) | |||
There was a problem hiding this comment.
I don't mind using Regex, but let's extract this to a constant in the global scope so the regex doesn't get re-created with each invocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description
Proposal to allow aliased parameter values to contain an equals sign. for example, something like:
-c formula=x=1+1An alternative could be to have a way to escape the value, though that opens a shell can of worms.
Opening this as a draft as a way to get comments before I go and dig into the failing tests this causes. (I realise some may disagree with this change)
Here's an example with a better description:
Say you have a field
formulayou would like to hold a string that contains an equals character. As per the example above, the formula could bex=x+1. The desired outcome would be the equivalent of this ts:const formula = "x=x+1".This case is articulated in the test I believe, though I could be wrong :)
Cheers!