Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for deno in test suite #1579

Merged
merged 2 commits into from
Nov 7, 2023
Merged

add support for deno in test suite #1579

merged 2 commits into from
Nov 7, 2023

Conversation

tim-smart
Copy link
Member

@tim-smart tim-smart commented Oct 30, 2023

  • docgen fix for markdown-toc dependency
  • add deno task test to CI
  • generate Deno import map

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2023

⚠️ No Changeset found

Latest commit: 15a4b2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pixeleet
Copy link

pixeleet commented Nov 7, 2023

@tim-smart With latest deno 1.38 tests seems to work with the unstable-byonm flag enabled

image

@pixeleet
Copy link

pixeleet commented Nov 7, 2023

Alternatively just doing deno --unstable-byonm task test does the same trick

@tim-smart tim-smart marked this pull request as ready for review November 7, 2023 21:45
@tim-smart
Copy link
Member Author

Alternatively just doing deno --unstable-byonm task test does the same trick

Well that certainly makes it easier :)

@tim-smart tim-smart merged commit 9023fbb into main Nov 7, 2023
7 checks passed
@tim-smart tim-smart deleted the deno branch November 7, 2023 21:46
@ryanleecode
Copy link

So for deno we can just use platform-node and it will work?

@pixeleet
Copy link

pixeleet commented Mar 23, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants