Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bw): tidy up Radio Setup menu #4939

Merged
merged 6 commits into from
May 30, 2024
Merged

Conversation

philmoz
Copy link
Collaborator

@philmoz philmoz commented Apr 29, 2024

Summary of changes:

  • Indent the 'Mode' label in the 'Sound' section.
  • Move the 'Contrast' setting to be directly under the 'Brightness' setting in the 'Backlight section'.
  • Indent the 'Contrast setting.

@inventor7777
Copy link

Very nice!

@3djc
Copy link
Collaborator

3djc commented Apr 30, 2024

I think we should move away from the indent been part of the translation string and use INDENT_WIDTH or similar in lcdDrawText() instead. It helps a lot when you have to resue that word

@pfeerick pfeerick added B&W Related generally to black and white LCD radios house keeping 🧹 Cleanup of code and house keeping labels Apr 30, 2024
@philmoz
Copy link
Collaborator Author

philmoz commented May 2, 2024

I think we should move away from the indent been part of the translation string and use INDENT_WIDTH or similar in lcdDrawText() instead. It helps a lot when you have to resue that word

I've cleaned up the usage of the INDENT macro in the code and replaced it with INDENT_WIDTH.
Cleaning up all the translation strings is a big job and probably something for another PR.

@3djc
Copy link
Collaborator

3djc commented May 2, 2024

Clearly, one step at a time!

@pfeerick
Copy link
Member

pfeerick commented May 2, 2024

GRAPHICS was another 9x legacy define... so good riddance!

@pfeerick pfeerick changed the title chore(b&w): tidy up Radio Setup menu on B&W radios. chore(bw): tidy up Radio Setup menu May 2, 2024
@pfeerick pfeerick added this to the 2.11 milestone May 2, 2024
@pfeerick pfeerick self-requested a review May 5, 2024 03:43
@philmoz philmoz force-pushed the bw-radio-setup-menu branch 2 times, most recently from ec60cb9 to 9df9622 Compare May 14, 2024 11:57
Copy link
Member

@pfeerick pfeerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also. Nice to see the GPS header for those options, as well as optimisation of some of the translation helper code. I noticed while reviewing that the "Default channel order" parameter was out of alignment (and has been for a while) by one character so fixed that also.

@pfeerick pfeerick merged commit 9bdd566 into EdgeTX:main May 30, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B&W Related generally to black and white LCD radios house keeping 🧹 Cleanup of code and house keeping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants