Update ListModal props #4551
Closed
Update ListModal props #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
|
As mentioned in the other PR review, we might not need these changes after all, since we want to decouple the login-ui and GUI versions of these components. |
Jon-edge
force-pushed
the
jon/fix/asset-status-promo
branch
2 times, most recently
from
de1bf8f
to
f12a1fe
Compare
Jon-edge
force-pushed
the
jon/fix/list-modal-props
branch
from
e678e56
to
2ac7359
Compare
Copied from loginUI changes. Improve the API: Make it more descriptive of the functionality. This isn't a generic text input, but a search. Flip the logic and remove the need to specify a value when setting hideSearch.
Jon-edge
force-pushed
the
jon/fix/list-modal-props
branch
from
2ac7359
to
5752859
Compare
Jon-edge
force-pushed
the
jon/fix/asset-status-promo
branch
from
f12a1fe
to
8e5ac43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from loginUI changes.
Make it more specific to the functionality - hideSearch. Remove the need to specify a value when setting hideSearch.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-login-ui-rn#139
Requirements
If you have made any visual changes to the GUI. Make sure you have: