Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated FAQs Section #5762

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PranavJoshi18
Copy link

Tried to update the FAQs section in the README.md file. This is my first time so would be very happy for feedbacks!

closes #ISSUE-NO

What does this PR do?

Description of the task to be completed?

How can this be manually tested?

Any background context you want to provide?

Is there any relevant issue to this PR?

Screenshots (if appropriate)

Questions

Tried to update the FAQs section in the README.md file. This is my first time so would be very happy for feedbacks!
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord Server and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@PranavJoshi18
Copy link
Author

kindly review!

README.md Show resolved Hide resolved
Copy link

@Frenziecodes Frenziecodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯💯

Copy link

@SurajPratap10 SurajPratap10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Copy link

@MuhammadNoorani MuhammadNoorani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good, you updated it in a nice manner. Looks good. This is a feedback review from my side and Thank You for helping EddieHub community out.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some suggestions @PranavJoshi18! :)

@sagar1621
Copy link
Member

Looks good

Copy link

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😊

@kulkarniyash7
Copy link
Member

Existing documentation looks nice , I think we may not need to update it.

schmelto and others added 4 commits August 19, 2023 20:44
Co-authored-by: Christine Belzie <[email protected]>
Co-authored-by: Christine Belzie <[email protected]>
Co-authored-by: Christine Belzie <[email protected]>
Co-authored-by: Christine Belzie <[email protected]>
Copy link
Contributor

@schmelto schmelto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the Pull Request. Your branch seems to be behind the default branch main. Please can you update with the latest changes.


Full details

As changes are merged in, other PRs can get out of date, and will need to be updated.

  • Update your fork's default branch main
  • Merge main into your branch

Summary: 🛠️ This code needs a fix

@adonis-maara
Copy link

Thanks for your pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet