Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created nitesh.json #10304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Moon1Knight
Copy link

@Moon1Knight Moon1Knight commented Mar 23, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@github-actions github-actions bot added invalid Inappropriate or invalid for Hacktoberfest contributions ✍ chore: profile This label will be added on PR with request of Data json addition labels Mar 23, 2024
@Moon1Knight
Copy link
Author

Created nitesh.json #10304

kumarsonsoff3
kumarsonsoff3 previously approved these changes Mar 24, 2024
Copy link
Member

@kumarsonsoff3 kumarsonsoff3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename must be exactly same as your GitHub username. Please rename your filename here to Moon1Knight.json

Change nitesh.json --> Moon1Knight.json

Also make the below suggested change.

"name": "Follow my Open Source on GitHub",
"url": "https://github.com/Moon1knight",
"icon": "FaGithub"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this trailing comma here!

Suggested change
},
}

@kumarsonsoff3 kumarsonsoff3 dismissed their stale review March 24, 2024 07:52

Not an approving review, it require changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✍ chore: profile This label will be added on PR with request of Data json addition invalid Inappropriate or invalid for Hacktoberfest contributions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants