chore(aragonos): Remove check in upgrade command

EVMcrispr · May 23, 2023 · 607c2f5 · 607c2f5
1 parent 8b4e062
commit 607c2f5
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 22 deletions.
diff --git a/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts b/packages/evmcrispr/src/modules/aragonos/commands/upgrade.ts
@@ -1,11 +1,7 @@
 import { constants, utils } from 'ethers';
 import { isAddress } from 'ethers/lib/utils';
 
-import {
- ComparisonType,
- addressesEqual,
- checkArgsLength,
-} from '../../../utils';
+import { ComparisonType, checkArgsLength } from '../../../utils';
 import type { ICommand } from '../../../types';
 import type { AragonOS } from '../AragonOS';
 import { _aragonEns } from '../helpers/aragonEns';
@@ -83,10 +79,6 @@ export const upgrade: ICommand<AragonOS> = {
  );
  }
 
- if (addressesEqual(currentAppAddress, newAppAddress)) {
- throw new ErrorException(`trying to upgrade app to its current version`);
- }
-
  return [
  {
  to: kernel.address,

diff --git a/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts b/packages/evmcrispr/test/modules/aragonos/commands/upgrade.test.ts
@@ -163,17 +163,4 @@ describe('AragonOS > commands > upgrade <apmRepo> [newAppImplementationAddress]'
 
  await expectThrowAsync(() => interpreter.interpret(), error);
  });
-
- it('should fail when upgrading an app to the same version', async () => {
- const interpreter = createAragonScriptInterpreter([
- 'upgrade disputable-conviction-voting.open 1.0.0',
- ]);
- const c = findAragonOSCommandNode(interpreter.ast, 'upgrade')!;
- const error = new CommandError(
- c,
- `trying to upgrade app to its current version`,
- );
-
- await expectThrowAsync(() => interpreter.interpret(), error);
- });
 });