Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PIP-II linac #385

Open
wants to merge 9 commits into
base: development
Choose a base branch
from
Open

Add PIP-II linac #385

wants to merge 9 commits into from

Conversation

cemitch99
Copy link
Member

@cemitch99 cemitch99 commented Jun 21, 2023 •
edited by ax3l

Preliminary draft of PIP-II linac input file for ImpactX. Caution: This draft will require several updates.

  • Set up a TraceWin parser based on modifications to lume-tracewin
  • Construct a preliminary draft input file using default RF cavity and solenoid elements
  • Update quad and sol elements to support TraceWin units
  • Determine RF cavity absolute phase values, and correct the input file
  • Verify correct scaling/normalization of element field strengths
  • Preprocess field data files to extract Fourier components of 1D on-axis field

Follow-up:

  • Benchmark against TraceWin results

cemitch99 and others added 4 commits June 20, 2023 15:39
@cemitch99
Examples for 3D space charge benchmarking
9e8a779 
- Modified the initial beam size in the IOTA lens benchmark example.
- Added 2 benchmarks of 3D space charge for initial testing.
- Add documentation for 2 benchmarks with space charge.
- Add a benchmark example with space charge and periodic s-dependent focusing.
- Added an s-dependent example using a Kurth beam without space charge.
- Modified tolerance for IOTA lens benchmark example.
  Reduced tolerance to account for smaller initial beam size and
  improved preservation of invariants of motion.
- Modified tolerances of space charge examples to allow CI tests to
  pass when space charge is not active.

- Modified tolerance for space charge examples.
  These should fail unless space charge is turned on.
@cemitch99
Update input_kurth_10nC.in
a148ffc 
Selected numerical values for amr.n_cell, lattice.nslice, and geometry.prob_relative.
@cemitch99
Add draft of PIP-II linac lattice
0ff6893
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
d5c1251 
for more information, see https://pre-commit.ci
@ax3l ax3l added this to the Advanced Methods (SciDAC) milestone Jun 21, 2023
@cemitch99 cemitch99 requested a review from ax3l June 21, 2023 00:13
@ax3l ax3l added the component: tests examples, tests and benchmarks label Jun 21, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 30, 2023
View reviewed changes
examples/PIPII_linac/parse_lattice.py

# TraceWin Lattice Parsing

**IN DEVELOPMENT**

Check failure

Code scanning / CodeQL

Syntax error Error

Syntax Error (in Python 3).
examples/PIPII_linac/parse_lattice.py
Comment on lines +132 to +135
#elif t =='thin_steering':
# isteer += 1
# name = f'K{isteer}'
# line = f'{name}: kicker, L = 0'

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ax3l ax3l Awaiting requested review from ax3l

Assignees
No one assigned
Labels
component: tests examples, tests and benchmarks
Projects
None yet
Milestone
Advanced Methods (SciDAC)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cemitch99 @ax3l