Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DYN-6633: Define Data node revisions #15229

Merged
merged 12 commits into from
May 23, 2024
Merged

DYN-6633: Define Data node revisions #15229

merged 12 commits into from
May 23, 2024

Conversation

twastvedt
Copy link
Contributor

@twastvedt twastvedt commented May 17, 2024

Purpose

  • Simplify some code
  • Rename IsSupportedDataNodeType to EvaluateDefineDataNode for clarity.
  • Mark EvaluateDefineDataNode as Obsolete to indicate it may change (needs to be public for AST)
  • Make DefineDataNodeViewCustomization and DataNodeDynamoType internal.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6633

Copy link

github-actions bot commented May 17, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@saintentropy
Copy link
Contributor

LGTM

Copy link
Collaborator

@dnenov dnenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, a lot of simplifications to the code! Quite a few new ways of doing things. Everything looks good, only one idea - do you think we could rename 'IsAutoMode' to something better suited with the new 'Auto-detect' paradigm?

@twastvedt twastvedt merged commit 28909dd into master May 23, 2024
24 checks passed
@twastvedt twastvedt deleted the definedata-wrapup branch May 23, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants