Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving accessibility of telegram #1713

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improving accessibility of telegram #1713

wants to merge 4 commits into from

Conversation

AlexandrKozlovskiy
Copy link

@AlexandrKozlovskiy AlexandrKozlovskiy commented Jul 6, 2022 •
edited

In this pr i suggest several accessibility fixes and improvements.

  1. First of all i partially fixed accessibility bug,when blind users should swipe to scroll alot of times,if message contains alot of text,to go to the next node.
  2. Also i fixed moving by characters/words,etc with talkback,so now blind users can select and use diferents granularities with talkback.
  3. Also i tryed to fix,if in chat admin or owner write from channel or group name,to screenreader read it. I not tested it yet,but i hope,what it works ok.
  4. other fixes and improvements.

known issues.

All issues,which known on this moment,connected with accessibility scrolling of chat.

  1. During the scrolling sometimes focus jump to indefinite place or on some view out of list. This issue connected probably with incorrect coordinates,to which i scroll and probably with impossibility to get item for position,which invisible in screen. My idea,what top of node (even virtual view) should be at the top of screen.
  2. When we scroll to the end of the list,and after this we scroll back,jump to end button not appear. Probably we should call methods from ChatActivity class.
  3. Sometimes back scrolling not scroll to previous node (probably the same problems as in issue one).
    Even with this issues in my opinion accessibility scrolling become more better,when message contains alot of text,so if @xaxtix will merge my pr and fix issues,about which i wrote,blind users shouldn't swipe alot of times,if message have alot of text,because for now in official telegram for large messages we,blind users,should swipe sometimes ten,twenty or more times,to go to the next node,if message contains alot of text. Especially it actual,when we swipe right,i.ecall action scroll_forward.

@AlexandrKozlovskiy
Copy link
Author

I fixed bug,when percents not announced if user not vote and poll was closed. Also i added announcing during loading of some content.

@AlexandrKozlovskiy AlexandrKozlovskiy force-pushed the telegram_accessibility branch 3 times, most recently from 48ce9b5 to d7a3c77 Compare September 17, 2022 11:29
AlexandrKozlovskiy referenced this pull request Dec 6, 2022
@xaxtix
update to 9.1.6
0e17caa
AlexandrKozlovskiy referenced this pull request Dec 7, 2022
@xaxtix
update to 9.2.1
03e899e
AlexandrKozlovskiy referenced this pull request Dec 13, 2022
@xaxtix
update to 9.2.2
2c71f6c
@b0r1ngx
Copy link

b0r1ngx commented Dec 15, 2022

👍

AlexandrKozlovskiy referenced this pull request Dec 30, 2022
@xaxtix
update to 9.3.0
3ccf875
qwq233
qwq233 suggested changes Dec 31, 2022
View reviewed changes
TMessagesProj/src/main/java/org/telegram/ui/Cells/ChatMessageCell.java Outdated
@@ -765,8 +791,11 @@ public static class PollButton {
private Drawable[] selectorDrawable = new Drawable[2];
private int[] selectorDrawableMaskType = new int[2];
private RectF instantButtonRect = new RectF();
<<<<<<< HEAD
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

TMessagesProj/src/main/java/org/telegram/ui/Cells/ChatMessageCell.java
default boolean needPlayMessage(MessageObject messageObject, boolean muted) {
return false;
}

default boolean drawingVideoPlayerContainer() {
return false;
return false;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reformat code pls

@AlexandrKozlovskiy
Copy link
Author

@qwq233 Now all ok? I updated commit via amend

@AlexandrKozlovskiy AlexandrKozlovskiy force-pushed the telegram_accessibility branch 3 times, most recently from ffa5933 to d947ae7 Compare July 26, 2023 19:07
@AlexandrKozlovskiy AlexandrKozlovskiy force-pushed the telegram_accessibility branch 5 times, most recently from 3c60c0a to b34f0db Compare January 3, 2024 18:38
@AlexandrKozlovskiy AlexandrKozlovskiy force-pushed the telegram_accessibility branch 2 times, most recently from 007abda to 4429061 Compare May 2, 2024 19:23
@AlexandrKozlovskiy AlexandrKozlovskiy force-pushed the telegram_accessibility branch 2 times, most recently from c633f05 to d428252 Compare May 3, 2024 19:28
@Aokromes
Copy link

Aokromes commented May 21, 2024 •
edited

it's bad idea to mix prs (accesibility + mem leak), also, the smaller the prs the higher chance of being merged.

@AlexandrKozlovskiy
Copy link
Author

@Aokromes It can be merged partially. I hope get some reply from @dkaraush about future of my pr.

@Aokromes
Copy link

partial merges of PRs is a pita, it's better to send one pr for accesibility thing and another for memleak fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwq233 qwq233 qwq233 requested changes

@Rappid6974 Rappid6974 Rappid6974 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@AlexandrKozlovskiy @b0r1ngx @Aokromes @qwq233 @Rappid6974