Do not call setSecret on any unmasked secrets
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not directly tested this logic yet, wanted to see what the GitHub action would say. I will look at trying to test this logic internally as well. |
Right now, every value that's pulled from Doppler is marked as a secret in GitHub Actions, which means any workflow using this action ends up with a ton of unnecessary redactions. For example, if you have the following Doppler values: ``` NODE_ENV = test WORKER_COUNT = 3 ``` Then *every* output that includes `test` and the number 3 gets redacted, making the output rather difficult to read. Now I'm unable to tell the real difference between Listing and Downloading secrets, but from what I can tell from the [api docs](https://docs.doppler.com/reference/secrets-list) only List Secrets includes the visibility information, so I had to change how secrets are pulled. Fixes DopplerHQ#16
jasonroelofs
force-pushed
the
do-not-redact-unmasked-secrets
branch
from
2c81a01
to
1e2a087
Compare
jasonroelofs
force-pushed
the
do-not-redact-unmasked-secrets
branch
from
7799d55
to
3d1469d
Compare
|
Did some internal testing and got this to a state where it works! |
watsonian
requested changes
Mar 15, 2024
watsonian
approved these changes
Mar 15, 2024
|
Anything I need to do about the test failures? |
|
Ping @watsonian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, every value that's pulled from Doppler is marked as a secret in GitHub Actions, which means any workflow using this action ends up with a ton of unnecessary redactions.
For example, if you have the following Doppler values:
Then every output that includes
testand the number 3 gets redacted, making the output rather difficult to read. Now I'm unable to tell the real difference between Listing and Downloading secrets, but from what I can tell from the apidocs only List Secrets includes the visibility information, so I had to change how secrets are pulled.
Fixes #16