Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing issue #604 : Adds effect plot visualizer #993

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

naresh-bachwani
Copy link
Contributor

@naresh-bachwani naresh-bachwani commented Nov 11, 2019

This PR refers to issue #604. It adds effect plots to 'yellowbrick/regressors'.
It has the following features:

  1. Auto identification of discrete and continuous columns.
  2. Hyperparams for custom plots.

Sample Code and Plot

from yellowbrick.regressor.effect import EffectPlot
from yellowbrick.datasets import load_bikeshare
from sklearn.linear_model import LinearRegression
X, y = load_bikeshare()
viz = EffectPlot(LinearRegression(), colormap='cool')
viz.fit(X, y)
viz.poof(outpath = 'Effect.png')

Effect

TODOs and questions

Still to do:

  • Provide parameter which allows users to define discrete and continuous features.
  • Add test_effect.py
  • Add Documentation.

Questions for the @DistrictDataLabs/team-oz-maintainers:

CHECKLIST

  • Is the commit message formatted correctly?
  • Have you noted the new functionality/bugfix in the release notes of the next release?
  • Included a sample plot to visually illustrate your changes?
  • Do all of your functions and methods have docstrings?
  • Have you added/updated unit tests where appropriate?
  • Have you updated the baseline images if necessary?
  • Have you run the unit tests using pytest?
  • Is your code style correct (are you using PEP8, pyflakes)?
  • Have you documented your new feature/functionality in the docs?
  • Have you built the docs using make html?

@naresh-bachwani naresh-bachwani changed the title [WIP] Addressing issue #604 : Adds effect plot visualizer Addressing issue #604 : Adds effect plot visualizer Dec 28, 2019
@wagner2010 wagner2010 self-assigned this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants