example 22 now tests emulated_float64_t #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Examples-and-Tests into emulated_float64_t
Comment on lines
+584
to
+607
| TestValues expectedTestValues = { | ||
| .intCreateVal = static_cast<emulated::emulated_float64_t::storage_t>(24.0), | ||
| .uintCreateVal = static_cast<emulated::emulated_float64_t::storage_t>(24u), | ||
| .uint64CreateVal = static_cast<emulated::emulated_float64_t::storage_t>(24ull), | ||
| .floatCreateVal = static_cast<emulated::emulated_float64_t::storage_t>(1.2f), | ||
| .doubleCreateVal = static_cast<emulated::emulated_float64_t::storage_t>(1.2), | ||
| .additionVal = emulated::emulated_float64_t::create(30.0), | ||
| .substractionVal = emulated::emulated_float64_t::create(10.0), | ||
| .multiplicationVal = emulated::emulated_float64_t::create(200.0), | ||
| .divisionVal = emulated::emulated_float64_t::create(2.0), | ||
| .lessOrEqualVal = false, | ||
| .greaterOrEqualVal = true, | ||
| .equalVal = false, | ||
| .notEqualVal = true, | ||
| .lessVal = false, | ||
| .greaterVal = true, | ||
| .convertionToBoolVal = true, | ||
| .convertionToIntVal = 20, | ||
| .convertionToUint32Val = 20u, | ||
| .convertionToUint64Val = 20ull, | ||
| .convertionToFloatVal = 20.0f, | ||
| .convertionToDoubleVal = 20.0, | ||
| //.convertionToHalfVal = 20; | ||
| }; |
There was a problem hiding this comment.
what you could do is use xoroshiro64** or somethign similar to come up with 64bit patterns denoting individual lhs and rhs values, then runs same code on CPU and GPU for a few hundred/thousand "random" doubles and see if you match
Obviously the create with different data types, and handling of Inf and NaN in operators needs to be tested specially, but you get the flow.
The more of the operation/input matching code you can hoist to a common HLSL/C++ header the better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.