Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dxDiagram types, arrange "commands" props types (T1227506) #27344

Merged
merged 13 commits into from May 21, 2024

Conversation

mpreyskurantov
Copy link
Contributor

@mpreyskurantov mpreyskurantov commented May 9, 2024

Cherry-picks

Changelog:

  • all enums / unions (except for DiagramExportFormat because of enum name conflict): @public + @namespace DevExpress.ui.dxDiagram (with the dxDiagram scope - to avoid naming conflicts in a bundle similar to the other components)
  • dxDiagramCustomCommand: @public (@namespace DevExpress.ui already exists - no the dxDiagram scope - the type name already starts with dxDiagram, i.e., an unique / component-basis prefix), interface -> type
    • trim the leading (dx)Diagram prefix
    • add module-based type re-exports and a bundle based aliases

All published types become available in framework packages re-exports

  • all props, which can be of both types Array<dxDiagramCustomCommand>|Array<Enums.DiagramCommand> - now have this type in d.ts (Array<CustomCommand | Command>) without doc tag override (note that in react we cannot add a real enum / union type import, but use indi acc values instead, otherwise - BC)
  • correct demos, where affected props refer to input values with as any

Docs:
DevExpress/devextreme-documentation#6302
DevExpress/devextreme-documentation#6322

@mpreyskurantov mpreyskurantov self-assigned this May 9, 2024
@mpreyskurantov mpreyskurantov requested review from a team as code owners May 9, 2024 16:07
@mpreyskurantov mpreyskurantov changed the title Publish dxDiagram Types (T1227506) Publish dxDiagram Types, arrange props of dxDiagramCustomCommand | DiagramCommand types (T1227506) May 10, 2024
mpreyskurantov added a commit to mpreyskurantov/devextreme-documentation that referenced this pull request May 10, 2024
@mpreyskurantov mpreyskurantov changed the title Publish dxDiagram Types, arrange props of dxDiagramCustomCommand | DiagramCommand types (T1227506) Publish dxDiagram types, arrange "commands" props types (T1227506) May 11, 2024
romanresh
romanresh previously approved these changes May 13, 2024
IlyaKhD
IlyaKhD previously approved these changes May 20, 2024
@mpreyskurantov mpreyskurantov merged commit b4d9b2d into DevExpress:24_1 May 21, 2024
272 checks passed
mpreyskurantov added a commit to mpreyskurantov/DevExtreme that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants