Optimize hymd #386
Optimize hymd #386
Conversation
This thread pool is designed for the use case where there are many batches of similar tasks. The thread pool can be waited on without requiring the creation of threads again, and in each batch resources can be shared between tasks that happen to be done on a single thread. For example, we may only allocate a buffer once per batch per thread, or even fewer times if tasks in separated batches are the same, instead of allocating it for every single task.
Allows modifying predicates in EraseIfReplace
This slightly reduces performance
Makes MdLattice more testable.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| assert(!NotEmpty(cur_node.rhs_bounds)); | ||
| assert(cur_node_index > md.lhs_specialization.specialized.index); | ||
| auto const& [rhs_index, rhs_bound] = md.rhs; | ||
| auto set_bound = [&](MdNode* node) { node->rhs_bounds[rhs_index] = rhs_bound; }; |
There was a problem hiding this comment.
warning: Dereference of undefined pointer value [clang-analyzer-core.NullDereference]
auto set_bound = [&](MdNode* node) { node->rhs_bounds[rhs_index] = rhs_bound; };
^Additional context
src/core/algorithms/md/hymd/lattice/md_lattice.cpp:174: '?' condition is true
assert(!NotEmpty(cur_node.rhs_bounds));
^/usr/include/assert.h:92: expanded from macro 'assert'
(static_cast <bool> (expr) \
^src/core/algorithms/md/hymd/lattice/md_lattice.cpp:175: Assuming 'cur_node_index' is > field 'index'
assert(cur_node_index > md.lhs_specialization.specialized.index);
^/usr/include/assert.h:92: expanded from macro 'assert'
(static_cast <bool> (expr) \
^src/core/algorithms/md/hymd/lattice/md_lattice.cpp:175: '?' condition is true
assert(cur_node_index > md.lhs_specialization.specialized.index);
^/usr/include/assert.h:92: expanded from macro 'assert'
(static_cast <bool> (expr) \
^src/core/algorithms/md/hymd/lattice/md_lattice.cpp:178: Calling 'AddUnchecked<algos::hymd::lattice::MdLattice::MdNode, (lambda at /github/workspace/src/core/algorithms/md/hymd/lattice/md_lattice.cpp:178:22)>'
AddUnchecked(&cur_node, md.lhs_specialization.old_lhs, cur_node_index, set_bound);
^src/core/algorithms/md/hymd/lattice/node_base.h:70: '?' condition is true
assert(cur_node_ptr->IsEmpty());
^/usr/include/assert.h:92: expanded from macro 'assert'
(static_cast <bool> (expr) \
^src/core/algorithms/md/hymd/lattice/node_base.h:71: Loop condition is false. Execution continues on line 79
for (MdElement element = lhs.FindNextNonZero(cur_node_index); lhs.IsNotEnd(element);
^src/core/algorithms/md/hymd/lattice/node_base.h:78: Calling 'operator()'
final_node_action(cur_node_ptr);
^src/core/algorithms/md/hymd/lattice/md_lattice.cpp:177: Dereference of undefined pointer value
auto set_bound = [&](MdNode* node) { node->rhs_bounds[rhs_index] = rhs_bound; };
^
src/core/algorithms/md/hymd/md_lhs.h
Outdated
| template <> | ||
| struct hash<algos::hymd::MdLhs> { | ||
| std::size_t operator()(algos::hymd::MdLhs const& p) const noexcept { | ||
| return hash<algos::hymd::DecisionBoundaryVector>{}(p.GetValues()); |
There was a problem hiding this comment.
warning: no member named 'DecisionBoundaryVector' in namespace 'algos::hymd' [clang-diagnostic-error]
return hash<algos::hymd::DecisionBoundaryVector>{}(p.GetValues());
^| NewBounds new_bounds_; | ||
|
|
||
| public: | ||
| class update_iterator { |
There was a problem hiding this comment.
warning: invalid case style for class 'update_iterator' [readability-identifier-naming]
| class update_iterator { | |
| class UpdateIterator { |
src/core/algorithms/md/hymd/utility/invalidated_rhss.h:25:
- update_iterator(InvalidatedIterator invalidated_iter, NewBoundsIterator new_bounds_iter)
+ UpdateIterator(InvalidatedIterator invalidated_iter, NewBoundsIterator new_bounds_iter)src/core/algorithms/md/hymd/utility/invalidated_rhss.h:35:
- update_iterator operator++() {
+ UpdateIterator operator++() {src/core/algorithms/md/hymd/utility/invalidated_rhss.h:41:
- update_iterator operator++(int) {
- update_iterator old = *this;
+ UpdateIterator operator++(int) {
+ UpdateIterator old = *this;src/core/algorithms/md/hymd/utility/invalidated_rhss.h:47:
- friend bool operator==(update_iterator const& iter1, update_iterator const& iter2) {
+ friend bool operator==(UpdateIterator const& iter1, UpdateIterator const& iter2) {src/core/algorithms/md/hymd/utility/invalidated_rhss.h:51:
- friend bool operator!=(update_iterator const& iter1, update_iterator const& iter2) {
+ friend bool operator!=(UpdateIterator const& iter1, UpdateIterator const& iter2) {src/core/algorithms/md/hymd/utility/invalidated_rhss.h:67:
- update_iterator UpdateIterBegin() const {
+ UpdateIterator UpdateIterBegin() const {src/core/algorithms/md/hymd/utility/invalidated_rhss.h:71:
- update_iterator UpdateIterEnd() const {
+ UpdateIterator UpdateIterEnd() const {Decreases runtime for datasets where inference from record pairs is the optimal algorithm.
No description provided.