Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: "next_sales_window_purchase_start" ATTR #194

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

swiezaczek
Copy link

No description provided.

@swiezaczek
Copy link
Author

None shows up instead of next sales date, so it needs future modifications and tests

@swiezaczek swiezaczek closed this Nov 5, 2022
Copy link
Owner

@Der-Henning Der-Henning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note my comments and provide an item_id of an item that contains the attribute.

src/models/item.py Outdated Show resolved Hide resolved
@Der-Henning
Copy link
Owner

If you want to update your PR you don't have to close it. You can always add additional commits. Mark the PR as draft if you are not ready for merge.

@swiezaczek swiezaczek reopened this Nov 5, 2022
Co-authored-by: Henning Merklinger <[email protected]>
@swiezaczek swiezaczek marked this pull request as draft November 5, 2022 21:18
@swiezaczek
Copy link
Author

swiezaczek commented Nov 5, 2022

Thanks for a good tip. Item that should contain this attribute : 55738
Screenshot_20221105_222016

I don't know why it shows NONE/NA when in the app I can see Check again at 21:00 tommorow
How can I get full response for get_item to see if attribute is there? I believe its hidden when item is still available

---edit:

This attribute won't work for scrapping favourite items as it uses get_items and the function works only with get_item, so it should work with items that are manually added in config.ini

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants