Save Database.json with gzip #164
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvegter
reviewed
Sep 14, 2019
| return custPath; | ||
| } | ||
|
|
||
| if (File.Exists(Locations.File.DatabaseGzip)) |
There was a problem hiding this comment.
Are we going to prefer Gzip version or should this be a user option as default saving strategy?
There was a problem hiding this comment.
I haven't thought of any necessity for user options, although I have imagined it to be switchable.
| @@ -576,7 +617,9 @@ public bool IsType(int appId, AppType appType) | |||
|
|
|||
| public void Load() | |||
There was a problem hiding this comment.
See previous comment regarding user/profile option regarding saving strategy.
Co-Authored-By: Martijn Vegter <[email protected]>
Co-Authored-By: Martijn Vegter <[email protected]>
|
@yfdyh000 I have done some changes on the master branch, be sure to update asap to prevent any conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #162.
This is a dirty implementation for #162, including hard-coded, non-reusable, no tests, etc. I originally planned it as new functions or a new user option.
I see that the compression ratio is about 4%, which is huge. Database writes are infrequent, but it seems to occur at startup, and perhaps multiple loops when a particular operation.
Thanks to https://stackoverflow.com/questions/32943899/can-i-decompress-and-deserialize-a-file-using-streams.