Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[whatwg-url] update specification link for percentDecodeString() #69637

Merged

Conversation

azerum
Copy link
Contributor

@azerum azerum commented May 18, 2024

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 18, 2024

@azerum Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69637,
  "author": "azerum",
  "headCommitOid": "a2824dab3575205c570335cd4d8ecede61fbf354",
  "mergeBaseOid": "425f0ebe145ac9337b0bcbd1084a548d729b4963",
  "lastPushDate": "2024-05-18T10:55:01.000Z",
  "lastActivityDate": "2024-05-18T10:55:01.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "whatwg-url",
      "kind": "edit",
      "files": [
        {
          "path": "types/whatwg-url/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "aomarks",
        "ExE-Boss",
        "BendingBender"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [],
  "mainBotCommentID": 2118777728,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Critical package Untested Change This PR does not touch tests labels May 18, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 18, 2024
@typescript-bot
Copy link
Contributor

🔔 @aomarks @ExE-Boss @BendingBender — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 18, 2024
@peterblazejewicz peterblazejewicz merged commit a138e8e into DefinitelyTyped:master May 18, 2024
4 checks passed
@typescript-bot typescript-bot removed this from Needs Maintainer Review in New Pull Request Status Board May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical package Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants