Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@types/three] Add missing mode argument for TransformControls.d.ts events #69503

Closed
wants to merge 1 commit into from

Conversation

s-rigaud
Copy link

@s-rigaud s-rigaud commented May 2, 2024

The TransformControls actually returns the mode each time mouseDown and mouseUp events are triggered (same behaviour for older library versions).

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented May 2, 2024

@s-rigaud Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 Only a DT maintainer can approve changes without tests

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 13 days.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69503,
  "author": "s-rigaud",
  "headCommitOid": "3c873b0f3a9ac8d273945395e2a6dd8ae1cb515b",
  "mergeBaseOid": "1243e1a4d11bb863290220ddb6fd678526bf4d47",
  "lastPushDate": "2024-05-02T23:37:31.000Z",
  "lastActivityDate": "2024-05-03T12:27:08.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "three",
      "kind": "edit",
      "files": [
        {
          "path": "types/three/examples/jsm/controls/TransformControls.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "joshuaellis",
        "Methuselah96"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "changereq",
      "reviewer": "Methuselah96",
      "date": "2024-05-03T12:27:08.000Z"
    }
  ],
  "mainBotCommentID": 2091910201,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Untested Change This PR does not touch tests labels May 2, 2024
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board May 2, 2024
@typescript-bot
Copy link
Contributor

🔔 @joshuaellis @Methuselah96 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in New Pull Request Status Board May 2, 2024
Copy link
Contributor

@Methuselah96 Methuselah96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s-rigaud Thanks for the PR! Can you create this at https://github.com/three-types/three-ts-types? That is where the three.js types are maintained. Sorry for the inconvenience.

@typescript-bot typescript-bot added the Revision needed This PR needs code changes before it can be merged. label May 3, 2024
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Needs Author Action in New Pull Request Status Board May 3, 2024
@typescript-bot
Copy link
Contributor

@s-rigaud One or more reviewers has requested changes. Please address their comments. I'll be back once they sign off or you've pushed new commits. Thank you!

@s-rigaud s-rigaud closed this May 17, 2024
@typescript-bot typescript-bot removed this from Needs Author Action in New Pull Request Status Board May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Popular package This PR affects a popular package (as counted by NPM download counts). Revision needed This PR needs code changes before it can be merged. Untested Change This PR does not touch tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants