Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[npm-registry-fetch] Add authType field to AuthOptions #69478

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arayaryoma
Copy link
Contributor

@arayaryoma arayaryoma commented Apr 30, 2024

The authType option is used as npm-auth-type request header field. ref:

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot typescript-bot added this to Needs Author Action in New Pull Request Status Board Apr 30, 2024
@arayaryoma arayaryoma marked this pull request as ready for review April 30, 2024 16:01
@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 30, 2024

@arayaryoma Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners, DT maintainers or others

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Inactive

This PR has been inactive for 19 days — please merge or say something if there's a problem, otherwise it will be closed!


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69478,
  "author": "arayaryoma",
  "headCommitOid": "6063c40c269013b5c2601ba7eea29c958542ff4c",
  "mergeBaseOid": "778ad7a80e9876f258270d84d1db4e6e1d5e3796",
  "lastPushDate": "2024-04-30T15:59:25.000Z",
  "lastActivityDate": "2024-05-05T06:58:01.000Z",
  "mergeOfferDate": "2024-05-05T06:58:39.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": "npm-registry-fetch",
      "kind": "edit",
      "files": [
        {
          "path": "types/npm-registry-fetch/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/npm-registry-fetch/npm-registry-fetch-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "Anonymous4078",
      "date": "2024-05-05T06:58:01.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2085778673,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the No Other Owners This DT module only has one owner, so we can't have someone verify the change. label Apr 30, 2024
@typescript-bot
Copy link
Contributor

🔔 @arayaryoma — there are no owners, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Apr 30, 2024
@typescript-bot typescript-bot added Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner labels May 5, 2024
@typescript-bot
Copy link
Contributor

@arayaryoma: Everything looks good here. I am ready to merge this PR (at 6063c40) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Waiting for Author to Merge in New Pull Request Status Board May 5, 2024
@typescript-bot typescript-bot added the Unmerged The author did not merge the PR when it was ready. label May 15, 2024
@typescript-bot
Copy link
Contributor

Re-ping @arayaryoma / @«anyone?»:

This PR has been ready to merge for over a week, and I haven't seen any requests to merge it. I will close it on Jun 4th (in three weeks) if this doesn't happen.

(If there's no reason to avoid merging it, please do so. Otherwise, if it shouldn't be merged or if it needs more time, please close it or turn it into a draft.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Other Owners This DT module only has one owner, so we can't have someone verify the change. Other Approved This PR was reviewed and signed-off by a community member. Self Merge This PR can now be self-merged by the PR author or an owner Unmerged The author did not merge the PR when it was ready.
Projects
New Pull Request Status Board
Waiting for Author to Merge
Development

Successfully merging this pull request may close these issues.

None yet

3 participants