🤖 Merge PR #68023 [react-bootstrap-table] Stop testing react-dom by @…

…eps1lon
DefinitelyTyped · Dec 29, 2023 · 0730ea3 · 0730ea3
1 parent b7bc0d9
commit 0730ea3
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 26 deletions.
diff --git a/types/react-bootstrap-table/package.json b/types/react-bootstrap-table/package.json
@@ -9,8 +9,7 @@
  "@types/react": "*"
  },
  "devDependencies": {
- "@types/react-bootstrap-table": "workspace:.",
- "@types/react-dom": "*"
+ "@types/react-bootstrap-table": "workspace:."
  },
  "owners": [
  {

diff --git a/types/react-bootstrap-table/react-bootstrap-table-tests.tsx b/types/react-bootstrap-table/react-bootstrap-table-tests.tsx
@@ -35,7 +35,6 @@ import {
  TableHeaderColumn,
  ToolBarProps,
 } from "react-bootstrap-table";
-import { render } from "react-dom";
 
 interface Product {
  id: number;
@@ -92,16 +91,13 @@ function priceFormatter(cell: number, row: Product) {
  return "<i class=\"glyphicon glyphicon-usd\"></i> " + cell;
 }
 
-render(
- <BootstrapTable data={products} striped={true} hover={true} ignoreSinglePage>
- <TableHeaderColumn dataField="id" isKey={true} dataAlign="center" dataSort={true}>Product ID</TableHeaderColumn>
- <TableHeaderColumn dataField="name" dataSort={true} editable={{ type: "textarea", rows: 10 }}>
- Product Name
- </TableHeaderColumn>
- <TableHeaderColumn dataField="price" dataFormat={priceFormatter}>Product Price</TableHeaderColumn>
- </BootstrapTable>,
- document.getElementById("app"),
-);
+<BootstrapTable data={products} striped={true} hover={true} ignoreSinglePage>
+ <TableHeaderColumn dataField="id" isKey={true} dataAlign="center" dataSort={true}>Product ID</TableHeaderColumn>
+ <TableHeaderColumn dataField="name" dataSort={true} editable={{ type: "textarea", rows: 10 }}>
+ Product Name
+ </TableHeaderColumn>
+ <TableHeaderColumn dataField="price" dataFormat={priceFormatter}>Product Price</TableHeaderColumn>
+</BootstrapTable>;
 
 const qualityType = {
  0: "good",

diff --git a/types/react-bootstrap-table/v2/package.json b/types/react-bootstrap-table/v2/package.json
@@ -10,8 +10,7 @@
  "@types/react": "*"
  },
  "devDependencies": {
- "@types/react-bootstrap-table": "workspace:.",
- "@types/react-dom": "*"
+ "@types/react-bootstrap-table": "workspace:."
  },
  "owners": [
  {

diff --git a/types/react-bootstrap-table/v2/react-bootstrap-table-tests.tsx b/types/react-bootstrap-table/v2/react-bootstrap-table-tests.tsx
@@ -1,6 +1,5 @@
 import * as React from "react";
 import { ApplyFilterParameter, BootstrapTable, Filter, TableHeaderColumn } from "react-bootstrap-table";
-import { render } from "react-dom";
 
 const products = [{
  id: 1,
@@ -17,16 +16,13 @@ function priceFormatter(cell: any, row: any) {
  return "<i class=\"glyphicon glyphicon-usd\"></i> " + cell;
 }
 
-render(
- <BootstrapTable data={products} striped={true} hover={true} ignoreSinglePage>
- <TableHeaderColumn dataField="id" isKey={true} dataAlign="center" dataSort={true}>Product ID</TableHeaderColumn>
- <TableHeaderColumn dataField="name" dataSort={true} editable={{ type: "textarea", rows: 10 }}>
- Product Name
- </TableHeaderColumn>
- <TableHeaderColumn dataField="price" dataFormat={priceFormatter}>Product Price</TableHeaderColumn>
- </BootstrapTable>,
- document.getElementById("app"),
-);
+<BootstrapTable data={products} striped={true} hover={true} ignoreSinglePage>
+ <TableHeaderColumn dataField="id" isKey={true} dataAlign="center" dataSort={true}>Product ID</TableHeaderColumn>
+ <TableHeaderColumn dataField="name" dataSort={true} editable={{ type: "textarea", rows: 10 }}>
+ Product Name
+ </TableHeaderColumn>
+ <TableHeaderColumn dataField="price" dataFormat={priceFormatter}>Product Price</TableHeaderColumn>
+</BootstrapTable>;
 
 const qualityType = {
  0: "good",