Suppress tool execution during kernel builds #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the kbuild portion to the top of Makefile and conditionalize the rest. This avoids error output from trying to execute sudo, pidof and other tools in an isolated buid environment where they might not be available and are not needed. Signed-off-by: Andreas Färber <[email protected]>
SivaThirunavukkarasu
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the kbuild portion of the Makefile to the top and conditionalize the rest.
Cf. https://www.kernel.org/doc/html/latest/kbuild/modules.html#shared-makefile
This avoids error output from trying to execute
sudo,pidofand other tools while initializing Makefile variables in an isolated buid environment where the packages might not be available.