fix(llmobs): fix propagation memory usage [backport 2.9] #9392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This PR is a follow up of #9152, and attempts to minimize any added memory overhead by moving the `llmobs` utility import to inside the conditional check that `LLMObs` is enabled. By importing inside the `ddtrace.llmobs.` directory we are implicitly running the `ddtrace.llmobs.__init__.py` code, which involves instantiating a `LLMObs` instance. This is likely the largest culprit of the memory overhead. Moving the import to only happening if LLMObs is enabled should avoid that added overhead, given that LLMObs is only running in a select few customer applications at the moment. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) (cherry picked from commit be9936b)
github-actions
bot
added
the
changelog/no-changelog
Yun-Kim
added
changelog/no-changelog
Yun-Kim
approved these changes
May 24, 2024
Datadog ReportBranch report: ✅ 0 Failed, 8358 Passed, 50223 Skipped, 3h 14m 40.79s Total duration (5h 46m 34.95s time saved) |
emmettbutler
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport be9936b from #9387 to 2.9.
This PR is a follow up of #9152, and attempts to minimize any added memory overhead by moving the
llmobsutility import to inside the conditional check thatLLMObsis enabled.By importing inside the
ddtrace.llmobs.directory we are implicitly running theddtrace.llmobs.__init__.pycode, which involves instantiating aLLMObsinstance. This is likely the largest culprit of the memory overhead.Moving the import to only happening if LLMObs is enabled should avoid that added overhead, given that LLMObs is only running in a select few customer applications at the moment.
Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist