fix(tracing): fix traceback max size for exceptions [backport 2.9] #9391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
#7558 made the traceback size configurable via `DD_SPAN_TRACEBACK_MAX_SIZE`, but tracebacks for exceptions were still hardcoded with a limit of 30. The fix is modeled after `Span#set_traceback`'s existing logic, and tests were modeled after both `test_traceback_with_error` and `test_custom_traceback_size`. Not much new logic, just an edge case. ## Checklist - [x] Change(s) are motivated and described in the PR description - [x] Testing strategy is described if automated tests are not included in the PR - [x] Risks are described (performance impact, potential for breakage, maintainability) - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html) are followed or label `changelog/no-changelog` is set - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)) - [x] Backport labels are set (if [applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)) - [x] If this PR changes the public interface, I've notified `@DataDog/apm-tees`. ## Reviewer Checklist - [x] Title is accurate - [x] All changes are related to the pull request's stated goal - [x] Description motivates each change - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes - [x] Testing strategy adequately addresses listed risks - [x] Change is maintainable (easy to change, telemetry, documentation) - [x] Release note makes sense to a user of the library - [x] Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment - [x] Backport labels are set in a manner that is consistent with the [release branch maintenance policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting) Co-authored-by: erikayasuda <[email protected]> (cherry picked from commit 1b954de)
erikayasuda
approved these changes
May 24, 2024
Datadog ReportBranch report: ✅ 0 Failed, 169808 Passed, 2258 Skipped, 9h 30m 36.51s Total duration (1h 17m 36.31s time saved) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.9 #9391 +/- ##
===========================================
- Coverage 27.73% 10.30% -17.43%
===========================================
Files 1259 1256 -3
Lines 119987 120081 +94
===========================================
- Hits 33280 12377 -20903
- Misses 86707 107704 +20997 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1b954de from #9112 to 2.9.
#7558 made the traceback size configurable via
DD_TRACE_SPAN_TRACEBACK_MAX_SIZE, but tracebacks for exceptions were still hardcoded with a limit of 30.The fix is modeled after
Span#set_traceback's existing logic, and tests were modeled after bothtest_traceback_with_errorandtest_custom_traceback_size. Not much new logic, just an edge case.Checklist
changelog/no-changelogis set@DataDog/apm-tees.Reviewer Checklist