Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry): enabling dd_trace_sample_ignore_parent for otel sampler #9384

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ddmclav
Copy link
Contributor

@ddmclav ddmclav commented May 24, 2024

Description

Adding support for otel trace sampler to ignore parent trace sample rate from dd-trace-py.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@ddmclav ddmclav changed the title fix(opentelemetry): enabling DD_TRACE_SAMPLE_IGNORE_PARENT for OTEL values fix(opentelemetry): enabling dd_trace_sample_ignore_parent for otel sampler May 24, 2024
@ddmclav ddmclav added the changelog/no-changelog A changelog entry is not required for this PR. label May 24, 2024
@datadog-dd-trace-py-rkomorn
Copy link

Datadog Report

Branch report: ignoretraceparent
Commit report: 4903ac6
Test service: dd-trace-py

✅ 0 Failed, 99082 Passed, 42564 Skipped, 2h 27m 49.99s Total duration (4h 24m 19.08s time saved)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant