Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade helper to use WAF 1.18.0 #2660

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

@estringana estringana commented May 8, 2024

Description

Does all required changes(https://github.com/DataDog/libddwaf/blob/master/UPGRADING.md) to accommodate to WAF version 1.18.0

APPSEC-52611

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana force-pushed the estringana/upgrade-to-waf-1.17 branch 2 times, most recently from 5febabe to f6cebfc Compare May 14, 2024 15:33
@estringana estringana marked this pull request as ready for review May 15, 2024 13:17
@estringana estringana requested a review from a team as a code owner May 15, 2024 13:17
@estringana estringana changed the title Upgrade helper to use WAF 1.17.0 Upgrade helper to use WAF 1.18.0 May 21, 2024
Copy link
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments for now.

appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Outdated Show resolved Hide resolved
appsec/src/helper/network/proto.hpp Outdated Show resolved Hide resolved
appsec/src/helper/client.cpp Show resolved Hide resolved
appsec/src/helper/engine.cpp Outdated Show resolved Hide resolved
@estringana estringana force-pushed the estringana/upgrade-to-waf-1.17 branch from b7cf5b6 to 7abbcf8 Compare June 11, 2024 15:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.85%. Comparing base (4bbc100) to head (e343070).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2660      +/-   ##
============================================
- Coverage     79.40%   77.85%   -1.55%     
  Complexity     2212     2212              
============================================
  Files           201      227      +26     
  Lines         22544    26569    +4025     
  Branches          0      989     +989     
============================================
+ Hits          17901    20686    +2785     
- Misses         4643     5357     +714     
- Partials          0      526     +526     
Flag Coverage Δ
appsec-extension 69.19% <80.00%> (?)
tracer-extension 78.63% <ø> (ø)
tracer-php 80.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
appsec/src/extension/commands_helpers.c 69.62% <80.00%> (ø)

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbc100...e343070. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants