Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path to Symfony Route defaults #2590

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

'Symfony\Component\Routing\Annotation\Route',
'__construct',
null,
function ($This) use ($integration) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible, I would only run this on CLI executions

@pr-commenter
Copy link

pr-commenter bot commented Mar 21, 2024

Benchmarks

Benchmark execution time: 2024-03-27 08:56:12

Comparing candidate commit 7c6b6c7 in PR branch estringana/cache-symfony-path with baseline commit 7eb4638 in branch master.

Found 1 performance improvements and 4 performance regressions! Performance is the same for 177 metrics, 0 unstable metrics.

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

  • 🟩 execution_time [-145.563ns; -118.637ns] or [-8.589%; -7.000%]

scenario:LogsInjectionBench/benchLogsInfoInjection-opcache

  • 🟥 execution_time [+218.135ns; +449.265ns] or [+2.404%; +4.951%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+5.700µs; +8.316µs] or [+2.036%; +2.971%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+10.440µs; +12.535µs] or [+3.428%; +4.115%]
  • 🟥 mem_peak [+99.680KB; +99.680KB] or [+4.422%; +4.422%]

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Merging #2590 (7c6b6c7) into master (7eb4638) will decrease coverage by 14.18%.
Report is 19 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2590       +/-   ##
=============================================
- Coverage     77.07%   62.90%   -14.18%     
  Complexity     2563     2563               
=============================================
  Files           215      215               
  Lines         23048    23061       +13     
=============================================
- Hits          17765    14507     -3258     
- Misses         5283     8554     +3271     
Flag Coverage Δ
tracer-extension 78.70% <ø> (ø)
tracer-php 43.36% <0.00%> (-31.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ations/Integrations/Symfony/SymfonyIntegration.php 0.00% <0.00%> (-83.29%) ⬇️

... and 32 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb4638...7c6b6c7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants