Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Add user event to Laravel #2509

Open
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

estringana
Copy link
Contributor

@estringana estringana commented Feb 7, 2024

Description

Set user on authenticated request on Laravel framework

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

APPSEC-14732

@pr-commenter
Copy link

pr-commenter bot commented Feb 7, 2024

Benchmarks

Benchmark execution time: 2024-04-25 08:27:50

Comparing candidate commit bf37a1e in PR branch estringana/add-user-event-to-laravel with baseline commit 6d15aec in branch master.

Found 3 performance improvements and 1 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟩 execution_time [-17.604µs; -14.861µs] or [-9.036%; -7.628%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-15.548µs; -7.716µs] or [-8.178%; -4.059%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟩 execution_time [-15.734µs; -8.846µs] or [-8.119%; -4.564%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟥 execution_time [+6.969µs; +9.931µs] or [+3.942%; +5.617%]

@estringana estringana force-pushed the estringana/add-user-event-to-laravel branch 2 times, most recently from 73b2e69 to daa142c Compare February 8, 2024 09:57

This comment has been minimized.

3 similar comments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

4 similar comments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@estringana estringana force-pushed the estringana/add-user-event-to-laravel branch from 2353c8b to 6d77a47 Compare February 12, 2024 11:52

This comment has been minimized.

1 similar comment

This comment has been minimized.

@estringana estringana force-pushed the estringana/add-user-event-to-laravel branch from c92c876 to 4c79720 Compare February 12, 2024 16:16

This comment has been minimized.

@estringana estringana force-pushed the estringana/add-user-event-to-laravel branch 3 times, most recently from a981924 to 73e0ba8 Compare February 13, 2024 15:45

This comment has been minimized.

This comment has been minimized.

3 similar comments

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

@PROFeNoM PROFeNoM force-pushed the estringana/add-user-event-to-laravel branch from 6faee49 to 8d875aa Compare February 14, 2024 14:50

This comment has been minimized.

@estringana estringana force-pushed the estringana/add-user-event-to-laravel branch from bf0816e to bf37a1e Compare April 25, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants