Explicitly disable appsec in setup script #2011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When --enable-appsec is not passed, this explicitly disables it in the setup script. This is because, since its release 0.7.0, appsec is effectively on by default.
|
ASM isn't enabled by default when the value is unset, but rather we launch the daemon so that users can enable ASM through remote configuration, however requests aren't processed in this mode. This PR would break ASM 1-click activation. cc: @estringana |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
--enable-appsecis not passed, this explicitly disablesdatadog.appsec.enabledin the setup script rather than relying on the default.This is because, since its release 0.7.0, appsec is effectively on by default. See DataDog/dd-appsec-php#242, which this works around.
Readiness checklist
Reviewer checklist