Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to compiled version of files in CI #1413

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

labbati
Copy link
Member

@labbati labbati commented Dec 15, 2021

Description

By default DD_AUTOLOAD_NO_COMPILE must be false (or not set) so in CI we are sure that we always test the compiled version, that is what we ship to users.

In development, we can constantly avoid recompilation by doing make >>>dev<<< test_*** which sets DD_AUTOLOAD_NO_COMPILE=true while running the tests locally, without having to regenerate PHP files bundles.

Readiness checklist

  • [ ] (only for Members) Changelog has been added to the release document.
  • [ ] Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@labbati labbati added this to the 0.68.0 milestone Dec 15, 2021
@labbati labbati modified the milestones: 0.68.0, future Dec 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2021

Codecov Report

Merging #1413 (5d00e44) into master (b61f79f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1413   +/-   ##
=======================================
  Coverage   78.16%   78.16%           
=======================================
  Files         170      170           
  Lines       15389    15389           
=======================================
  Hits        12029    12029           
  Misses       3360     3360           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61f79f...5d00e44. Read the comment docs.

@bwoebi bwoebi requested a review from a team as a code owner September 23, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants