Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update github.com/DataDog/sketches-go to v1.4.5 #2698

Merged
merged 6 commits into from
May 21, 2024

Conversation

darccio
Copy link
Contributor

@darccio darccio commented May 17, 2024

What does this PR do?

Upgrades sketches-go to v1.4.5, reducing the dependency area with github.com/golang/protobuf.

Motivation

Removing github.com/golang/protobuf from our go.mod, as third party vulnerability scanners tend to warn about it, even if it's not compiled into the final binary.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio darccio requested review from a team as code owners May 17, 2024 10:56
@github-actions github-actions bot added the apm:ecosystem contrib/* related feature requests or bugs label May 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 17, 2024

Benchmarks

Benchmark execution time: 2024-05-21 11:28:49

Comparing candidate commit dc7b892 in PR branch dario.castane/upgrade-sketches-go-v1.4.5 with baseline commit 5c8a345 in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 40 metrics, 1 unstable metrics.

scenario:BenchmarkPartialFlushing/Disabled-24

  • 🟩 execution_time [-8.308ms; -5.833ms] or [-2.894%; -2.032%]

scenario:BenchmarkPartialFlushing/Enabled-24

  • 🟩 execution_time [-9.102ms; -5.908ms] or [-3.192%; -2.072%]

scenario:BenchmarkSingleSpanRetention/no-rules-24

  • 🟩 execution_time [-6.262µs; -5.321µs] or [-2.552%; -2.168%]

@darccio darccio merged commit d823db5 into main May 21, 2024
200 checks passed
@darccio darccio deleted the dario.castane/upgrade-sketches-go-v1.4.5 branch May 21, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:ecosystem contrib/* related feature requests or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants