-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump the buildimage to use Python 3.11.8 #25703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
[Fast Unit Tests Report] On pipeline 34576677 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience |
Regression DetectorRegression Detector ResultsRun ID: 315e4f80-3331-4917-9845-a08d90c4395c Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI |
---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +2.53 | [+0.16, +4.90] |
➖ | tcp_syslog_to_blackhole | ingress throughput | +2.02 | [-19.31, +23.36] |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.90 | [-0.96, +4.76] |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.71 | [-4.06, +5.48] |
➖ | otel_to_otel_logs | ingress throughput | +0.09 | [-0.30, +0.47] |
➖ | trace_agent_msgpack | ingress throughput | +0.01 | [+0.00, +0.02] |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.20, +0.21] |
➖ | trace_agent_json | ingress throughput | -0.00 | [-0.01, +0.01] |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.01 | [-0.06, +0.04] |
➖ | file_tree | memory utilization | -0.03 | [-0.13, +0.06] |
➖ | idle | memory utilization | -0.25 | [-0.29, -0.21] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue Pull request added to the queue. This build is next! (estimated merge in less than 55m) Use |
What does this PR do?
Bump the buildimage to use Python 3.11.8
Motivation
We need DataDog/datadog-agent-buildimages#591
Additional Notes
rpm-s3
is py2 only so I just make sure it is running with the right version because it is declared aspython
: https://github.com/DataDog/rpm-s3/blob/master/bin/rpm-s3#L1Possible Drawbacks / Trade-offs
Describe how to test/QA your changes