Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the buildimage to use Python 3.11.8 #25703

Merged
merged 4 commits into from
May 21, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented May 17, 2024

What does this PR do?

Bump the buildimage to use Python 3.11.8

Motivation

We need DataDog/datadog-agent-buildimages#591

Additional Notes

rpm-s3 is py2 only so I just make sure it is running with the right version because it is declared as python: https://github.com/DataDog/rpm-s3/blob/master/bin/rpm-s3#L1

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@FlorentClarret FlorentClarret added this to the 7.55.0 milestone May 17, 2024
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code labels May 17, 2024
@FlorentClarret FlorentClarret marked this pull request as ready for review May 17, 2024 15:04
@FlorentClarret FlorentClarret requested a review from a team as a code owner May 17, 2024 15:04
Copy link
Member

@amenasria amenasria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented May 17, 2024

[Fast Unit Tests Report]

On pipeline 34576677 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@FlorentClarret FlorentClarret requested a review from a team as a code owner May 17, 2024 16:42
@pr-commenter
Copy link

pr-commenter bot commented May 17, 2024

Regression Detector

Regression Detector Results

Run ID: 315e4f80-3331-4917-9845-a08d90c4395c
Baseline: 1eb7adc
Comparison: 1c4c0ee

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
basic_py_check % cpu utilization +2.53 [+0.16, +4.90]
tcp_syslog_to_blackhole ingress throughput +2.02 [-19.31, +23.36]
uds_dogstatsd_to_api_cpu % cpu utilization +1.90 [-0.96, +4.76]
pycheck_1000_100byte_tags % cpu utilization +0.71 [-4.06, +5.48]
otel_to_otel_logs ingress throughput +0.09 [-0.30, +0.47]
trace_agent_msgpack ingress throughput +0.01 [+0.00, +0.02]
uds_dogstatsd_to_api ingress throughput +0.01 [-0.20, +0.21]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.06, +0.04]
file_tree memory utilization -0.03 [-0.13, +0.06]
idle memory utilization -0.25 [-0.29, -0.21]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented May 21, 2024

🚂 MergeQueue

Pull request added to the queue.

This build is next! (estimated merge in less than 55m)

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 0634e14 into main May 21, 2024
204 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/bump_buildimage_python branch May 21, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-ci-experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants