Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTINT-3702] Send container snapshotter info in container check #25695

Closed
wants to merge 2 commits into from

Conversation

AliDatadog
Copy link
Contributor

@AliDatadog AliDatadog commented May 17, 2024

What does this PR do?

This PR:

  • adds snapshotter information in workloadmeta (commit 1).
  • sends the data in the container check (commit 2).

Motivation

Additional Notes

DataDog/agent-payload#313 needs to be merged first and we need to make a new release of agent-payload

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Deploy the agent in a containerized environment. Make sure agent workload-list -v shows container snapshotters. Make sure agent stream-event-platform shows Container payloads with the snapshotter field correctly set, with and without remote workloadmeta.

@pr-commenter
Copy link

pr-commenter bot commented May 17, 2024

Regression Detector

Regression Detector Results

Run ID: c293379a-40d5-4c72-ad2c-d9f8e34de21b
Baseline: c939559
Comparison: 7d20026

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
tcp_syslog_to_blackhole ingress throughput +7.38 [-15.01, +29.77]
file_tree memory utilization +0.22 [+0.11, +0.32]
otel_to_otel_logs ingress throughput +0.02 [-0.34, +0.38]
uds_dogstatsd_to_api ingress throughput +0.01 [-0.20, +0.21]
trace_agent_json ingress throughput -0.00 [-0.01, +0.01]
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.03, +0.03]
trace_agent_msgpack ingress throughput -0.02 [-0.03, -0.01]
idle memory utilization -0.29 [-0.33, -0.26]
uds_dogstatsd_to_api_cpu % cpu utilization -0.64 [-3.48, +2.20]
pycheck_1000_100byte_tags % cpu utilization -2.04 [-6.75, +2.68]
basic_py_check % cpu utilization -2.31 [-4.69, +0.06]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@AliDatadog AliDatadog changed the title [CONTINT-3702] Add Snapshotter info in workloadmeta [CONTINT-3702] Send container snapshotter info in container check May 17, 2024
@pr-commenter
Copy link

pr-commenter bot commented May 17, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=34552836 --os-family=ubuntu

@AliDatadog AliDatadog closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant