Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2 #28

Open
wants to merge 7 commits into
base: github_issues
Choose a base branch
from
Open

Fixes #2 #28

wants to merge 7 commits into from

Conversation

samly97
Copy link

@samly97 samly97 commented Sep 1, 2020

"npm run build" works out of box

Fix "npm run start"

  • updated webpack to 4.44.1
  • updated "react-dev-utils" to 6.0.0

Above breaks "npm run build" ...

Following changes are to get both commands to work

  • the other dependency updates were to get "npm run build" working again
  • replace unused UglifyJs webpack plugin with TerserPlugin
  • modified InterpolationHtmlPlugin to reflect how it works with webpack 4.44.1
  • replaced "contentHash" with "hash" as contentHash clashes with webpack definition

DPTeamMember and others added 7 commits April 23, 2020 13:34
@DPTeamMember
Merge pull request #22 from DashboardPack/github_issues
50a7bfe 
GitHub issues
@dependabot
Bump webpack-dev-server from 3.0.0 to 3.10.3
823c57e 
Bumps [webpack-dev-server](https://github.com/webpack/webpack-dev-server) from 3.0.0 to 3.10.3.
- [Release notes](https://github.com/webpack/webpack-dev-server/releases)
- [Changelog](https://github.com/webpack/webpack-dev-server/blob/master/CHANGELOG.md)
- [Commits](webpack/webpack-dev-server@v3.0.0...v3.10.3)

Signed-off-by: dependabot[bot] <[email protected]>
@dpackdev
Merge pull request #23 from DashboardPack/dependabot/npm_and_yarn/web…
42395c7 
…pack-dev-server-3.10.3

Bump webpack-dev-server from 3.0.0 to 3.10.3
@samly97
config/paths.js
ab937ce 
- point app build to backend assets folder

config/webpack.config.[].js
- remove static from assets so img, css, js, etc are the children directory
  of the backend assets folder: i.e. assets/react/[child]

package.json
- have assets point to the correct URL --> assets/react
@samly97
add package-lock.json to gitignore
561e2fa
@samly97
fix run and build scripts by fixing dependencies
ce931fc
@samly97
change project settings to template's
e339de9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samly97 @DPTeamMember @dpackdev