Feat/inject list countries (#1) #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make list const to use in constructor * inject list of countryCodes
Daniel-Ioannou
requested changes
May 19, 2021
There was a problem hiding this comment.
@alfredo-handcash Thank you for the PR.
I not show what you try to implement on your PR, you add an new optional argument countryList at CountryListView but CountryListView is private in lib so there is no way to set the new argument outside of the lib. You have to add countryList argument in showCountryPicker and and pass it to CountryListView.
Thank you
Daniel-Ioannou
force-pushed
the
master
branch
from
8927a20
to
8de6b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all thank you for your time creating this package!! This is awesome!
I created this PR to customize the list of country codes because there are some countries like Argentina that has a different codes for mobile and phones.
Thank you!