Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Includes #1344

Closed

Conversation

iguessthislldo
Copy link
Member

Used a script to find places where a preprocessor include starts with the directory of the including file and removed that part of the path to turn it into a relative path.

Used a script to find places where a preprocessor include starts with
the directory of the including file and removed that part of the path to
turn it into a relative path. Assumed the possible include paths were
`ACE`, `TAO`, and `TAO/orbsvcs`.
@jwillemsen
Copy link
Member

Ok, this looks to work but personally I find it less obvious which file is included, I would prefer to keep the paths there

@iguessthislldo
Copy link
Member Author

I find it less obvious which file is included

It is missing the other part I'm trying to do in OpenDDS which is just using #include <> for non-relative includes. That way its more obvious. This is what's recommend by the C++ Core Guidelines,

@jwillemsen
Copy link
Member

It is missing the other part I'm trying to do in OpenDDS which is just using #include <> for non-relative includes. That way its more obvious. This is what's recommend by the C++ Core Guidelines,

Ok, but when we want to use #include <some_library/common.h> for ACE/TAO within the unit tests it looks much easier to keep the ace and tao prefix, that makes a global replace much easier than when you remove ace and tao right now

@iguessthislldo
Copy link
Member Author

If I understand you correctly, do you mean for example using ace/Reactor.h instead something like of ../../ace/Reactor.h in a test? If so I agree with you and these changes don't do anything like that. There are no changes outside of ACE/ace, ACE/ACEXML, TAO/tao, and TAO/orbsvcs.

@jwillemsen
Copy link
Member

If I understand you correctly, do you mean for example using ace/Reactor.h instead something like of ../../ace/Reactor.h in a test? If so I agree with you and these changes don't do anything like that. There are no changes outside of ACE/ace, ACE/ACEXML, TAO/tao, and TAO/orbsvcs.

I was thinking about <ace/Reactor.h> in a test, didn't notice you only changed core files, not tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants