Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Remove dead code path in ReplicateAndRegister #7653

Open
wants to merge 1 commit into
base: rel-v8r0
Choose a base branch
from

Conversation

chaen
Copy link
Contributor

@chaen chaen commented Jun 6, 2024

@chrisburr @andresailer I need a good review of that one :-) (not the RMS, that's just dead code)
Oyr FTS agents had half a billion of proxy files left... not with this anymore I hope :)

BEGINRELEASENOTES

*Core
CHANGE: register the DictCache destructor as an atexit handler

ENDRELEASENOTES

@DIRACGridBot DIRACGridBot added the alsoTargeting:integration Cherry pick this PR to integration after merge label Jun 6, 2024
@chaen chaen marked this pull request as draft June 7, 2024 08:18
@chrisburr
Copy link
Member

Isn't the issue here that the FTSAgent isn't passing a deleteFunction so there is nothing to delete the files?

@chaen
Copy link
Contributor Author

chaen commented Jun 10, 2024

Isn't the issue here that the FTSAgent isn't passing a deleteFunction so there is nothing to delete the files?

I don't think it is, as the ProxyManagerClient which the FTS3Agent uses has the proper delete function

self.__filesCache = DictCache(self.__deleteTemporalFile)

@chrisburr
Copy link
Member

Delightful! A global singleton and a reference cycle between DictCache and ProxyManagerClient. It's impossible for this object to ever get garbage collected.

I think the right way to fix this is: #7666

@chrisburr
Copy link
Member

I guess this should be rebased and renamed to just include the dead code removal.

@chaen chaen changed the title [8.0] Register an atexit callback for DictCache [8.0] Remove dead code path in ReplicateAndRegister Jun 25, 2024
@chaen chaen marked this pull request as ready for review June 25, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alsoTargeting:integration Cherry pick this PR to integration after merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants