Datafarm #6
Draft
Datafarm #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watobs/datafarm.py
Outdated
| zipped = zip( | ||
| o["schema"]["fields"], pj.build_table_schema(df, index=False)["fields"] | ||
| ) # ignoring index from the newly created frame | ||
| for m, l in zipped: |
There was a problem hiding this comment.
Please use slightly longer names (or at least avoid l as variable name) in for m, l in zipped
watobs/datafarm.py
Outdated
| response.raise_for_status() | ||
| self.access_token = response.headers["Access-Token"] | ||
| self.headers = {"Access-Token": self.access_token} | ||
| return self.access_token |
There was a problem hiding this comment.
Why do you return the access_token? Is that meaningful?
There was a problem hiding this comment.
I think you are right, it is better to leave it out.
|
|
||
| return to_pandas_df(json.dumps(data)) | ||
|
|
||
| def get_data( |
There was a problem hiding this comment.
Please
- rename time_series to time_series_id
- rename limit_row_count to limit
- rename range_start to start
- rename range_end to end
- start and end should be flexible in terms of type - make a private function _parse_datetime(dt) that outputs the desired str format. Use pd.to_datetime and dt.isoformat() + 'Z'
- use reasonable defaults for start = datetime.min and end = datetime.now()
jsmariegaard
requested changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft