Add repo2docker details to README #44
Conversation
|
|
MattF-NSIDC
force-pushed
the
readme-enhancement
branch
from
b62da78
to
83c647f
Compare
|
GitHub didn't suggest a reviewer for this PR, so I didn't know who to request and went with the person assigned to the only other open PR at the time. In my second PR, it suggested @weiji14 , so I've also added them here as well. Sorry if I've spammed anyone :) |
| @@ -6,6 +6,11 @@ | |||
| The JupyterHub docker image used for [hub.cryointhecloud.com](https://cryointhecloud.com), | |||
| hosted on https://quay.io/repository/cryointhecloud/cryo-hub-image | |||
|
|
|||
| The image is built with [repo2docker](https://repo2docker.readthedocs.io), which uses | |||
| Ubuntu Bionic Beaver (18.04) as the base image. If you'd like to run a test build | |||
There was a problem hiding this comment.
Just a note that there's a PR open to modify the base image in repo2docker at jupyterhub/repo2docker#909. I'm planning to update this to 22.04 as soon as possible, which would help with the git version and security issues you mentioned in #45.
There was a problem hiding this comment.
Awesome news! Should I omit the comment about 18.04 from this README and instead link to the relevant part of the repo2docker docs? Or leave it here and update the text once jupyterhub/repo2docker#909 is merged?
There was a problem hiding this comment.
Let's just leave it for now. That PR has been open since 2020, and I'm not sure if it's any closer to getting merged 😆
It wasn't immediately obvious to me that this repo was built with
repo2docker, so I added a paragraph of important details to the README.