Suggestions to improve the Docker primary examples. #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The use of the $CCPROOT env var requires it be exported first, and the individual example do mention that, so I think it should just be removed. 2) Add -e MODE to run.sh, without which run.sh fails 3) Add exports of CCP_IMAGE_PREFIX and CCP_IMAGE_TAG where to find them, to the example, without which run.sh also fails 4) Add the use of PGPASSWORD to the psql example, without which the user will have to review run.sh to figure out what the password is, giving the user a little extra work I am assuming these examples are meant for beginners getting familiar, so I believe they should just work. From them the reader will then be able to extract what one needs to deploy a proper container later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of the $CCPROOT env var requires it be exported first,
and the individual example do mention that, so I think it should
just be removed.
Add -e MODE to run.sh, without which run.sh fails
Add exports of CCP_IMAGE_PREFIX and CCP_IMAGE_TAG where to find
them, to the example, without which run.sh also fails
Add the use of PGPASSWORD to the psql example, without which
the user will have to review run.sh to figure out what the password
is, giving the user a little extra work
I am assuming these examples are meant for beginners getting familiar,
so I believe they should just work. From them the reader will then be
able to extract what one needs to deploy a proper container later.
Checklist:
Type of Changes:
What is the current behavior? (link to any open issues here)
Examples that don't work
What is the new behavior (if this is a feature change)?
Examples that work
Other information: