Add download entire period bundle feature #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add 00000 option * Add feature flag * Small fixes and tests
honkfestival
commented
Aug 28, 2020
Comment on lines
+100
to
+113
| keys = [tek( | ||
| rolling_start_interval_number: rsin, | ||
| transmission_risk_level: 8, | ||
| data: "3333333333333333", | ||
| ), tek( | ||
| rolling_start_interval_number: rsin, | ||
| transmission_risk_level: 8, | ||
| data: "4444444444444444", | ||
| ), tek( | ||
| rolling_start_interval_number: rsin, | ||
| transmission_risk_level: 8, | ||
| data: "5555555555555555", | ||
| ),] | ||
| assert_keys(export, keys, region: 'CA', date_number: current_date_number - 15, date_range: 15) |
There was a problem hiding this comment.
@maxneuvians this assertion was missing in the original PR and it looks like there was an extra key in the keys array; the 2222222222222222 key was missing from the export.
Is that correct behaviour?
There was a problem hiding this comment.
Yes it should be like this https://github.com/cds-snc/covid-alert-server/blob/master/test/retrieve_test.rb#L110-L129, sorry about that!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream cds-snc/covid-alert-server#176
@henrytao-me you should probably 馃帺 this one 馃槃