Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert to wafv2 resources and add relevant AWS managed rules #86

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

convert to wafv2 resources and add relevant AWS managed rules #86

wants to merge 1 commit into from

Conversation

stonith
Copy link
Contributor

@stonith stonith commented Jun 30, 2020

  • convert legacy waf rules to wafv2 with latest AWS provider
  • add AWSManagedRulesAmazonIpReputationList, AWSManagedRulesCommonRuleSet, AWSManagedRulesKnownBadInputsRuleSet, AWSManagedRulesLinuxRuleSet, and AWSManagedRulesSQLiRuleSet AWS managed rulesets
  • enabled cloudwatch metrics per rule
  • enable sampling for each rule except for the explicit ALLOW rule
  • enabled rate limiting for /claim-key, /new-key-claim*, and /upload

Upstream of cds-snc/covid-alert-server#118

@stonith stonith requested a review from Ginja June 30, 2020 19:42
honkfestival
honkfestival approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@honkfestival honkfestival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I only took a brief look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honkfestival honkfestival honkfestival approved these changes

@Ginja Ginja Awaiting requested review from Ginja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stonith @honkfestival