Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cvm-remote-fix #1917

Merged
merged 2 commits into from
Feb 21, 2024
Merged

cvm-remote-fix #1917

merged 2 commits into from
Feb 21, 2024

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Feb 20, 2024

No description provided.

@ucwong ucwong self-assigned this Feb 20, 2024
@ucwong ucwong marked this pull request as ready for review February 20, 2024 19:41
@ucwong ucwong added the bug Something isn't working label Feb 20, 2024
@ucwong ucwong linked an issue Feb 20, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (902bbae) 47.42% compared to head (560c015) 47.44%.
Report is 482 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1917      +/-   ##
==========================================
+ Coverage   47.42%   47.44%   +0.01%     
==========================================
  Files         568      568              
  Lines       68781    68782       +1     
==========================================
+ Hits        32622    32632      +10     
+ Misses      33618    33606      -12     
- Partials     2541     2544       +3     
Files Coverage Δ
cmd/cortex/cvm.go 3.22% <0.00%> (-0.04%) ⬇️

... and 11 files with indirect coverage changes

@ucwong ucwong marked this pull request as draft February 20, 2024 20:14
@ucwong ucwong marked this pull request as ready for review February 20, 2024 20:22
@ucwong ucwong merged commit 158300d into master Feb 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working remote-cvm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant