Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: use atomic type #1504

Merged
merged 1 commit into from
Apr 22, 2023
Merged

metrics: use atomic type #1504

merged 1 commit into from
Apr 22, 2023

Conversation

ucwong
Copy link
Member

@ucwong ucwong commented Apr 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 22, 2023

Codecov Report

Merging #1504 (0e2bc5f) into master (51b6aae) will increase coverage by 0.05%.
The diff coverage is 88.00%.

❗ Current head 0e2bc5f differs from pull request most recent head 34ea155. Consider uploading reports for the commit 34ea155 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1504      +/-   ##
==========================================
+ Coverage   52.13%   52.18%   +0.05%     
==========================================
  Files         474      474              
  Lines       59511    59517       +6     
==========================================
+ Hits        31025    31058      +33     
+ Misses      26132    26114      -18     
+ Partials     2354     2345       -9     
Impacted Files Coverage Δ
params/version.go 33.33% <ø> (ø)
metrics/gauge.go 44.64% <60.00%> (ø)
metrics/counter.go 38.77% <83.33%> (ø)
metrics/ewma.go 67.56% <100.00%> (ø)
metrics/meter.go 68.93% <100.00%> (+1.47%) ⬆️

... and 15 files with indirect coverage changes

@ucwong ucwong merged commit bd93f84 into master Apr 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant