common/math: fix out of bounds access in json unmarshalling (#30014)

Co-authored-by: Martin Holst Swende <[email protected]>
CortexFoundation · Jun 18, 2024 · 10920da · 10920da
1 parent 608c7f9
commit 10920da
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/math/big.go b/common/math/big.go
@@ -47,7 +47,7 @@ type HexOrDecimal256 big.Int
 // It is similar to UnmarshalText, but allows parsing real decimals too, not just
 // quoted decimal strings.
 func (i *HexOrDecimal256) UnmarshalJSON(input []byte) error {
- if len(input) > 0 && input[0] == '"' {
+ if len(input) > 1 && input[0] == '"' {
  input = input[1 : len(input)-1]
  }
  return i.UnmarshalText(input)

diff --git a/common/math/integer.go b/common/math/integer.go
@@ -46,7 +46,7 @@ type HexOrDecimal64 uint64
 // It is similar to UnmarshalText, but allows parsing real decimals too, not just
 // quoted decimal strings.
 func (i *HexOrDecimal64) UnmarshalJSON(input []byte) error {
- if len(input) > 0 && input[0] == '"' {
+ if len(input) > 1 && input[0] == '"' {
  input = input[1 : len(input)-1]
  }
  return i.UnmarshalText(input)