Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cold fix #148

Merged
merged 2 commits into from
May 29, 2024
Merged

cold fix #148

merged 2 commits into from
May 29, 2024

Conversation

yueyinqiu
Copy link
Member

@yueyinqiu yueyinqiu commented May 10, 2024 •
edited by pr-codex bot

水水水

PR-Codex overview

This PR updates ArchiveHelper methods to use the [MaybeNullWhen(false)] attribute for better nullability annotations.

Detailed summary

  • Added [MaybeNullWhen(false)] attribute to TryOpen method parameters in ArchiveHelper.cs
  • Updated method calls in GameResourcesResolveHelper.cs to reflect changes in ArchiveHelper

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 10, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yueyinqiu yueyinqiu changed the title archive is not null cold fix May 12, 2024
@laolarou726 laolarou726 merged commit 2c0b53e into Corona-Studio:master May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laolarou726 laolarou726 Awaiting requested review from laolarou726

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yueyinqiu @laolarou726